Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPS version of matmul in TTNN #15038

Open
azecevicTT opened this issue Nov 14, 2024 · 5 comments
Open

DPS version of matmul in TTNN #15038

azecevicTT opened this issue Nov 14, 2024 · 5 comments
Assignees
Labels

Comments

@azecevicTT
Copy link

Is there a reason why matmul (and linear) aren't modeled as DPS ops in TTNN? We model them as DPS ops in TTNN MLIR dialect, is there a plan to make them DPS ops in the future or should we change them to non DPS to reflect TTNN state.

@sdjordjevicTT
Copy link
Contributor

Hi @bbradelTT, we discovered this during our onboarding in the TT-MLIR compiler. Can you give us some feedback on whether this inconsistency in the matmul op is a limitation or just needs to be implemented from your side?

@bbradelTT
Copy link
Contributor

It just needs to be implemented from our side. The underlying device op has output tensors passed in to it that are created via operation::get_workers_for_op_output. It should be straightforward to expose that via an optional parameter. Having said that, the output tensor would need to be the right format, otherwise we would need to fail in validation.

How high of a priority would this work be for you and when would you need it by?

@sdjordjevicTT
Copy link
Contributor

sdjordjevicTT commented Nov 14, 2024

Thanks for the quick reply @bbradelTT! It isn't critical for now, but it would be great to have support for DPS matmul sometime in the near future, hence I will mark this as P1 if that sounds ok with you?

@bbradelTT
Copy link
Contributor

@sdjordjevicTT sounds good. @asandhupatlaTT will work on it.

@sdjordjevicTT
Copy link
Contributor

Great, thanks! Let's keep this issue open to track the progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants