You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a reason why matmul (and linear) aren't modeled as DPS ops in TTNN? We model them as DPS ops in TTNN MLIR dialect, is there a plan to make them DPS ops in the future or should we change them to non DPS to reflect TTNN state.
The text was updated successfully, but these errors were encountered:
Hi @bbradelTT, we discovered this during our onboarding in the TT-MLIR compiler. Can you give us some feedback on whether this inconsistency in the matmul op is a limitation or just needs to be implemented from your side?
It just needs to be implemented from our side. The underlying device op has output tensors passed in to it that are created via operation::get_workers_for_op_output. It should be straightforward to expose that via an optional parameter. Having said that, the output tensor would need to be the right format, otherwise we would need to fail in validation.
How high of a priority would this work be for you and when would you need it by?
Thanks for the quick reply @bbradelTT! It isn't critical for now, but it would be great to have support for DPS matmul sometime in the near future, hence I will mark this as P1 if that sounds ok with you?
Is there a reason why matmul (and linear) aren't modeled as DPS ops in TTNN? We model them as DPS ops in TTNN MLIR dialect, is there a plan to make them DPS ops in the future or should we change them to non DPS to reflect TTNN state.
The text was updated successfully, but these errors were encountered: