Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Programming Mesh of Devices Tech Report #14990

Closed
cfjchu opened this issue Nov 13, 2024 · 0 comments
Closed

Fixes to Programming Mesh of Devices Tech Report #14990

cfjchu opened this issue Nov 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cfjchu
Copy link
Collaborator

cfjchu commented Nov 13, 2024

@johanna-rock-tt reported a few typos and made some suggestions:

typos:
3.2 Programming Example: Sharding in the code below Let's now transfer to device the device ids don’t match the text below: in the example you have 0, 1 but int he text in the visualize_mesh_devices output you write about 11 and 10
In https://github.com/tenstorrent/tt-metal/blob/a39f99800564fa2bb02ebb231dc13cd2b8d92[…]ces/Programming%20Mesh%20of%20Devices%20with%20TT-NN.md?plain=1 you have a device_mesh with 2,4 grid, but you create a tensor with 32,128. I think this should be 32, 256 to have a tile on each device.
Same thing here: https://github.com/tenstorrent/tt-metal/blob/a39f99800564fa2bb02ebb231dc13cd2b8d92[…]ces/Programming%20Mesh%20of%20Devices%20with%20TT-NN.md?plain=1

I think it would also be helpful to indicate what the output dims are like (e.g. after gathering on dim=3 along cluster_axis=0 it would be 4 shards with size 32x128, sharded in width but replicated in height or similar)

@cfjchu cfjchu added the bug Something isn't working label Nov 13, 2024
cfjchu added a commit that referenced this issue Nov 13, 2024
…14991)

### Ticket
[Link to Github
Issue](#14990)

### Problem description
Address feedback on typos and suggestions.

### What's changed
Some minor fixes to typos and add more description to the
line-all-gather operation.


### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] New/Existing tests provide coverage for changes
@cfjchu cfjchu closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant