#14590: Move sfpi off LFS #14758
Open
#14590: Move sfpi off LFS #14758
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tt_metal/third_party/sfpi submodule. Add smarts to tt_metal/hw to download sfpi release into runtome/sfpi
nathan-TT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-rkim
reviewed
Nov 8, 2024
tt-rkim
approved these changes
Nov 12, 2024
|
Decided not to number after GCC releases, just use an incrementing major number. Started at 5 to avoid any meaning to it. |
arikTT
approved these changes
Nov 14, 2024
tt-dma
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tt_metal/third_party/sfpi submodule.
Add smarts to tt_metal/hw to download sfpi release into runtome/sfpi
Ticket
#14590
Problem description
LFS bad, don't use it.
What's changed
New reorg and release mechanism for sfpi -- see
tenstorrent/sfpi#24
Remove tt_metal/third_party/sfpi submodule
Add smarts to tt_metal/hw to lazily fetch a specific sfpi release (this patch names v0.0.0-lfsectomy, once we're set I'll create v12.0.0 -- numbering them after the GCC major/minor version numbering and use the micro number for our own updates.
Checklist