Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttnn.min_bw low PCC #14135

Closed
dveizovicTT opened this issue Oct 23, 2024 · 2 comments
Closed

ttnn.min_bw low PCC #14135

dveizovicTT opened this issue Oct 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working op_cat: eltwise WH

Comments

@dveizovicTT
Copy link

Describe the bug
ttnn.min_bw has low PCC for some inputs. For all failures PCC is around 0.998

To Reproduce
Steps to reproduce the behavior:
Checkout branch: dveizovic/binary-bw-ops-migration
Sweep test for tan is located in 'tests/sweep_framework/sweeps/eltwise/binary_backward/min_bw/min_bw.py'

  1. Go to 'tests/sweep_framework/sweeps/eltwise/unary_backward/rdiv_bw/rdiv_bw.py'
  2. Generate new parameter vectors and run the sweep test
python3 tests/sweep_framework/parameter_generator.py --elastic cloud --module-name eltwise.binary_backward.min_bw.min_bw
python3 tests/sweep_framework/runner.py --elastic cloud --module-name eltwise.binary_backward.min_bw.min_bw --suite-name nightly
  1. See the error. Results can be found on elastic cloud as explained here: https://github.com/tenstorrent/tt-metal/tree/main/tests/sweep_framework
@dveizovicTT dveizovicTT added bug Something isn't working WH op_cat: eltwise labels Oct 23, 2024
@VirdhatchaniKN VirdhatchaniKN self-assigned this Nov 7, 2024
@VirdhatchaniKN
Copy link
Contributor

Hi @dveizovicTT ,
I ran the above mentioned sweep test and found that the test has also been written for ROW_MAJOR Layout and bfloat8_b datatype. But according to the documentation,
Image
ttnn.min_bw only supports bfloat16 with TILE Layout combination.

Updating the test with above changes passes the test
Image

@VirdhatchaniKN
Copy link
Contributor

From PR #14133 ,
Image
final_test suite is passing, Hence closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working op_cat: eltwise WH
Projects
None yet
Development

No branches or pull requests

2 participants