Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update named attributes in commute_utils #704

Open
meenakshiramanathan1 opened this issue Nov 14, 2024 · 0 comments
Open

Update named attributes in commute_utils #704

meenakshiramanathan1 opened this issue Nov 14, 2024 · 0 comments
Assignees
Milestone

Comments

@meenakshiramanathan1
Copy link
Contributor

Commute_utils.cpp has overwrite_op_attrs in many parts of the function. But in these cases , named attributes are not updated and it will further lead to missing attributes error in mlir

Example:
error: 'ttir.concat' op All input tensors must have the same dimensions, except for dimension 1.

Above case was fixed in #675 PR. Updation of named attrs should be done throughout commute_utils stack.

@meenakshiramanathan1 meenakshiramanathan1 added this to the [FFE] Bringup milestone Nov 14, 2024
@meenakshiramanathan1 meenakshiramanathan1 self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant