Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops] Support for reduce average op (ttnn.mean) #114

Open
nvukobratTT opened this issue Aug 16, 2024 · 10 comments
Open

[Ops] Support for reduce average op (ttnn.mean) #114

nvukobratTT opened this issue Aug 16, 2024 · 10 comments
Assignees
Labels
Ops Support new op in tt-forge and tt-mlir

Comments

@nvukobratTT
Copy link
Contributor

No description provided.

@nvukobratTT nvukobratTT pinned this issue Aug 20, 2024
@nvukobratTT nvukobratTT unpinned this issue Aug 20, 2024
@nvukobratTT nvukobratTT self-assigned this Aug 22, 2024
nvukobratTT added a commit that referenced this issue Aug 22, 2024
Some ops are supported e2e, while others are blocked due to different reasons. Follow up issues will address failing cases.
@nvukobratTT
Copy link
Contributor Author

One group of ops fail because of the required squeeze (test setup and FFE op processing), while other group fails with tt-nn specific issues.

nvukobratTT added a commit that referenced this issue Aug 23, 2024
Some ops are supported e2e, while others are blocked due to different reasons. Follow up issues will address failing cases.
@nvukobratTT nvukobratTT added the Ops Support new op in tt-forge and tt-mlir label Sep 13, 2024
@nvukobratTT
Copy link
Contributor Author

@chandrasekaranpradeep this one is unblocked. Can you confirm if it works? :))

@chandrasekaranpradeep
Copy link
Contributor

chandrasekaranpradeep commented Sep 27, 2024

@nvukobratTT There are two test cases in the forge/test/mlir/test_ops.py

  1. test_reduce_mean
    In this test cases, TTNN: Issues with ttnn implicit reshape is resolved
    The below test cases alone is failing with pcc issue (PCC: 0.7203957195745748)
    pytest forge/test/mlir/test_ops.py::test_reduce_mean[-1-input_shape2] -vss
  2. test_mean
    In this test cases, the FFE: Unsupported squeeze operation issue is resolved, now all the test cases here are failing with Unable to reshape a tensor in TILE_LAYOUT to non-tile height and width! Please convert the tensor to ROW_MAJOR_LAYOUT first. issue

Logs:
test_mean.log
test_reduce_mean.log

@chandrasekaranpradeep
Copy link
Contributor

@nvukobratTT Created a PR for reduce average op test cases - #349

@chandrasekaranpradeep
Copy link
Contributor

Created a issue for the reduce average (i.e ttnn.mean) data mismatch
TT-MLIR - tenstorrent/tt-mlir#869
TT-Metal - tenstorrent/tt-metal#13621

Data Mismatch Failing Test cases:

Reduce_avg:
    Input_shape = (1, 12, 3200)
    dim = -1
    keep_dim = True
pytest forge/test/mlir/test_ops.py::test_reduce_mean[-1-input_shape2] -vss

@chandrasekaranpradeep
Copy link
Contributor

Created a issue for the reduce average (i.e ttnn.mean) data mismatch
TT-MLIR - tenstorrent/tt-mlir#869
TT-Metal - tenstorrent/tt-metal#13621

@nvukobratTT Reduce average op configuration (i.e Input_shape = (1, 12, 3200), dim = -1, keep_dim = True) is present in the Llama 3b model. Can we change the priority of the issue from P1 to P0?

@chandrasekaranpradeep
Copy link
Contributor

chandrasekaranpradeep commented Oct 9, 2024

In tt-metal latest main, Unable to reshape a tensor in TILE_LAYOUT to non-tile height and width! Please convert the tensor to ROW_MAJOR_LAYOUT first. issue is resolved for test_mean pytest.
Once the tt-mlir is uplifted with latest tt-metal main, need to verify the issue is resolved in forge or not and update the test_mean

@nvukobratTT
Copy link
Contributor Author

Created a issue for the reduce average (i.e ttnn.mean) data mismatch
TT-MLIR - tenstorrent/tt-mlir#869
TT-Metal - tenstorrent/tt-metal#13621

@nvukobratTT Reduce average op configuration (i.e Input_shape = (1, 12, 3200), dim = -1, keep_dim = True) is present in the Llama 3b model. Can we change the priority of the issue from P1 to P0?

Yup, I'll convert it right away :))

@nvukobratTT
Copy link
Contributor Author

In tt-metal latest main, Unable to reshape a tensor in TILE_LAYOUT to non-tile height and width! Please convert the tensor to ROW_MAJOR_LAYOUT first. issue is resolved for test_mean pytest. Once the tt-mlir is uplifted with latest tt-metal main, need to verify the issue is resolved in forge or not and update the test_mean

Yup! I think uplift of this one is already WIP :)) We expect it to land soon.

Please keep track of it and test out this op accordingly :))

@chandrasekaranpradeep
Copy link
Contributor

Yup! I think uplift of this one is already WIP :)) We expect it to land soon.
Please keep track of it and test out this op accordingly :))

Sure Nikola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ops Support new op in tt-forge and tt-mlir
Projects
None yet
Development

No branches or pull requests

2 participants