Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private-docs-rs feature should be propagated to tensorflow-sys. #336

Merged
merged 1 commit into from
Dec 20, 2021
Merged

private-docs-rs feature should be propagated to tensorflow-sys. #336

merged 1 commit into from
Dec 20, 2021

Conversation

dskkato
Copy link
Contributor

@dskkato dskkato commented Dec 17, 2021

The private-docs-rs feature was introduced to avoid large file downloading when building docs in docs.rs. However, this trigger was not propagated to tensorflow-sys which have broken the tensorflow doc in docs.rs. This patch is trying to resolve the following issues:

Resolves #255
Resolves #335

The private-docs-rs feature was introduced to avoid large file
downloading when building docs in docs.rs.
@dskkato dskkato changed the title private-docs-rs feature should be propagated to tensorflow-sys. private-docs-rs feature should be propagated to tensorflow-sys. Dec 17, 2021
@adamcrume
Copy link
Contributor

Hm, good catch. I hope this fixes it.

@adamcrume adamcrume merged commit ed59153 into tensorflow:master Dec 20, 2021
@dskkato dskkato deleted the fix_doc_build branch December 21, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that docs build on CI docs.rs broken
2 participants