Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert + add unit test folders #1720

Closed
wants to merge 5 commits into from
Closed

Revert + add unit test folders #1720

wants to merge 5 commits into from

Conversation

otherview
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2023 •
edited
Loading

Walkthrough

The changes encompass various aspects of the codebase, including adjustments to build workflows, modifications to TypeScript and Go files, and updates to configuration and utility files. These changes aim to refine build processes, improve gas usage efficiency, and enhance code readability and maintainability.

Changes

Files Change Summary
.github/workflows/build-pr.yml Ignored faucet, obscuroscan, and tengateway directories in the build process.
contracts/deployment_scripts/core/001_deploy_management_contract.ts Modified console log statement.
contracts/deployment_scripts/testnet/layer2/001_whitelist_tokens.ts Changed gasLimit value in DeployFunction.
go/config/enclave_cli_flags.go,
go/config/enclave_config.go,
go/config/enclave_config_test.go		 Updated and added flags, modified flag initializations.
go/enclave/components/batch_executor.go Added batchGasLimit field, updated function usage and parameter passing.
go/enclave/components/interfaces.go Modified method signature to remove parameters.
go/enclave/components/rollup_compression.go Removed line setting GasLimit field in a function.
go/enclave/crosschain/message_bus_manager.go Reduced Gas value in functions with a todo for review.
go/enclave/enclave.go Removed fields, adjusted function, and modified method usage.
go/enclave/evm/evm_facade.go Modified function signatures and return type.
go/enclave/l2chain/l2_chain.go,
go/enclave/nodetype/sequencer.go		 Added and updated fields, and modified method signatures.
integration/common/constants.go,
integration/datagenerator/common.go,
integration/simulation/devnetwork/node.go,
integration/simulation/network/network_utils.go,
integration/simulation/simulation.go,
testnet/launcher/cmd/cli.go,
tools/walletextension/api/routes.go,
tools/walletextension/api/utils.go,
tools/walletextension/wallet_extension.go		 Various modifications including value updates, error message changes, and method updates.
integration/constants.go Updated port constants used in the integration package.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples:
    • @coderabbitai render interesting statistics about this repository as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Dec 22, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c990832 and 84f9822.
Files selected for processing (1)
  • .github/workflows/build-pr.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/build-pr.yml

coderabbitai[bot]
coderabbitai bot reviewed Dec 22, 2023
View reviewed changes
tools/hardhatdeployer/contract_deployer.go
@@ -92,7 +92,7 @@ func (cd *contractDeployer) run() (string, error) {
deployContractTx := types.LegacyTx{
Nonce: cd.wallet.GetNonceAndIncrement(),
GasPrice: big.NewInt(1),
Gas: uint64(2_000_000),
Gas: uint64(2_900_000), // todo @pedro review this
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a TODO comment regarding the Gas value. Ensure that this is tracked in the project's issue tracking system and addressed before the code is deployed to production.

coderabbitai[bot]
coderabbitai bot reviewed Dec 22, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 996ec07 and 464c00b.
Files selected for processing (1)
  • integration/constants.go (2 hunks)
Additional comments: 3
integration/constants.go (3)

  • 6-16: Verify that the new port numbers do not conflict with other services on the network or within the application's ecosystem.

  • 27-29: Ensure that the new port offsets align with the updated port numbers and check for potential conflicts.

  • 3-19: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [6-29]

Check the entire codebase for references to the old port numbers to ensure they are updated to the new values.

coderabbitai[bot]
coderabbitai bot reviewed Dec 22, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 464c00b and a1aa9db.
Files selected for processing (3)
  • go/config/enclave_cli_flags.go (1 hunks)
  • go/enclave/crosschain/message_bus_manager.go (2 hunks)
  • integration/common/constants.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • go/config/enclave_cli_flags.go
  • go/enclave/crosschain/message_bus_manager.go
  • integration/common/constants.go

@otherview
Copy link
Contributor Author

Closed in pref of #1721

@otherview otherview closed this Dec 27, 2023
@otherview otherview deleted the pedro/full_revert branch December 27, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@otherview