Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate Google Analytics for OG and Obscuroscan #1638

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Jennievon
Copy link
Contributor

@Jennievon Jennievon commented Nov 8, 2023

Why this change is needed

Please provide a description and a link to the underlying ticket

https://github.com/obscuronet/obscuro-internal/issues/2387

What changes were made as part of this PR

Please provide a high level list of the changes made

Integrate Google Analytics for:

  • Obscuro Gateway
  • Obscuroscan

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

coderabbitai bot commented Nov 8, 2023

Walkthrough

The changes primarily involve updates to the analytics tracking configurations in two HTML files. The Google Analytics tracking ID has been updated in one file, while the other has had a Google Tag Manager script added for analytics. No changes have been made to the core functionality of the files, such as exported functions, global data structures, or interfaces.

Changes

File Path Change Summary
.../walletextension/api/staticOG/index.html Updated Google Analytics tracking ID from 'G-XL6VWGQK1P' to 'G-RPFRRG1S7F'.
.../obscuroscan_v2/frontend/index.html Added Google Tag Manager script for analytics. Modified charset, link, and meta tags. Added Google Analytics script with corresponding configuration. No changes to core functionality.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@Jennievon Jennievon requested review from 0xjba and CaisManai November 8, 2023 15:36
@Jennievon Jennievon self-assigned this Nov 8, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e7ab386 and c340a1e.
Files selected for processing (1)
  • tools/walletextension/api/staticOG/index.html (1 hunks)
Additional comments: 2
tools/walletextension/api/staticOG/index.html (2)
  • 15-15: Ensure that the new Google Analytics tracking ID 'G-RPFRRG1S7F' is correct and corresponds to the correct Google Analytics property.

  • 23-23: Ensure that the new Google Analytics tracking ID 'G-RPFRRG1S7F' is correct and corresponds to the correct Google Analytics property.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c340a1e and 601c4ae.
Files selected for processing (1)
  • tools/obscuroscan_v2/frontend/index.html (1 hunks)
Additional comments: 1
tools/obscuroscan_v2/frontend/index.html (1)
  • 1-22: Ensure that the new Google Analytics ID ('G-M82QX9RT4L') is correct and that it corresponds to the correct Google Analytics property. Also, verify that the Google Tag Manager script is correctly implemented and that it doesn't interfere with the loading of other scripts or the rendering of the page.

Copy link
Contributor

@0xjba 0xjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jennievon Jennievon merged commit 991a2d6 into main Nov 9, 2023
2 checks passed
@Jennievon Jennievon deleted the jennifer/goole-analytics#2387 branch November 9, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants