-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate Google Analytics for OG and Obscuroscan #1638
Conversation
WalkthroughThe changes primarily involve updates to the analytics tracking configurations in two HTML files. The Google Analytics tracking ID has been updated in one file, while the other has had a Google Tag Manager script added for analytics. No changes have been made to the core functionality of the files, such as exported functions, global data structures, or interfaces. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- tools/walletextension/api/staticOG/index.html (1 hunks)
Additional comments: 2
tools/walletextension/api/staticOG/index.html (2)
15-15: Ensure that the new Google Analytics tracking ID 'G-RPFRRG1S7F' is correct and corresponds to the correct Google Analytics property.
23-23: Ensure that the new Google Analytics tracking ID 'G-RPFRRG1S7F' is correct and corresponds to the correct Google Analytics property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- tools/obscuroscan_v2/frontend/index.html (1 hunks)
Additional comments: 1
tools/obscuroscan_v2/frontend/index.html (1)
- 1-22: Ensure that the new Google Analytics ID ('G-M82QX9RT4L') is correct and that it corresponds to the correct Google Analytics property. Also, verify that the Google Tag Manager script is correctly implemented and that it doesn't interfere with the loading of other scripts or the rendering of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why this change is needed
Please provide a description and a link to the underlying ticket
https://github.com/obscuronet/obscuro-internal/issues/2387
What changes were made as part of this PR
Please provide a high level list of the changes made
Integrate Google Analytics for:
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks