Obscuro Gateway Database Deploy #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkokelj
approved these changes
Sep 13, 2023
| && sudo snap refresh && sudo snap install --channel=1.18 go --classic \ | ||
| && curl -fsSL https://get.docker.com -o get-docker.sh && sh ./get-docker.sh \ | ||
| && git clone --depth 1 -b ${{ env.BRANCH_NAME }} https://github.com/obscuronet/go-obscuro.git /home/obscuro/go-obscuro \ | ||
| && docker network create --driver bridge node_network || true \ |
There was a problem hiding this comment.
|| true suppresses any errors. Is there any purpose for doing it?
I guess if any of the steps fail the deployment will not be sucessful
There was a problem hiding this comment.
Good point.
It does suppress errors but only for that if clause, so if other clauses fail then the command fails.
We want to forcibly create a node_network so that if we do create more containers they can intra-container communicate between them.
It's more of a standard, everywhere that we create docker containers we create the node-network (it then guarantees that all containers can communicate between them). Not sure if it's worth removing. Will remove it if you feel strongly about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
https://github.com/obscuronet/obscuro-internal/issues/2158
Adds a deployment for mariadb into a vm.
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks