-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tudor/aggressive header compression #1502
Changes from 6 commits
1b2d06c
d2365a4
7cc6550
7257251
123a9a6
29d7855
fefdd62
82845c0
7c3b885
eb2f1de
07b870a
3939223
3695298
9ddc5a3
9d171d3
07b8295
cc485c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -208,7 +208,7 @@ func ToExtRollupMsg(rollup *common.ExtRollup) generated.ExtRollupMsg { | |
return generated.ExtRollupMsg{} | ||
} | ||
|
||
return generated.ExtRollupMsg{Header: ToRollupHeaderMsg(rollup.Header), BatchPayloads: rollup.BatchPayloads, BatchHeaders: rollup.BatchHeaders} | ||
return generated.ExtRollupMsg{Header: ToRollupHeaderMsg(rollup.Header), BatchPayloads: rollup.BatchPayloads, BatchHeaders: rollup.CalldataRollupHeader} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's ok. It is the compressed batch headers There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I think the name is fine! But it seems like the |
||
} | ||
|
||
func ToRollupHeaderMsg(header *common.RollupHeader) *generated.RollupHeaderMsg { | ||
|
@@ -236,9 +236,9 @@ func FromExtRollupMsg(msg *generated.ExtRollupMsg) *common.ExtRollup { | |
} | ||
|
||
return &common.ExtRollup{ | ||
Header: FromRollupHeaderMsg(msg.Header), | ||
BatchPayloads: msg.BatchPayloads, | ||
BatchHeaders: msg.BatchHeaders, | ||
Header: FromRollupHeaderMsg(msg.Header), | ||
BatchPayloads: msg.BatchPayloads, | ||
CalldataRollupHeader: msg.BatchHeaders, | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field name and the description are confusing.