You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At this time, all public APIs that accept DataConverters require payload converter and failure converter to be specified as paths. That requirement originally stemmed from a desire of being consistent with the way DataConverters are passed to Workflow Workers, where paths are required because these two converters need to be loaded inside the Workflow Sandbox.
It however appears that in this specific case, consistency is often counter-productive. Workflow code and client code are often part of distinct deployment units, with distinct build processes for workflow vs client code, so that’s already inconsistent. By imposing consistency, we are forcing users to adapt and complexify the build process of all non-Workflow Worker components without no real reason to do so.
Instead, we should make Client accept pre-loaded data converters. And possibly do the same for Activity-only Workers.
The text was updated successfully, but these errors were encountered:
Describe the solution you'd like
At this time, all public APIs that accept
DataConverter
s require payload converter and failure converter to be specified as paths. That requirement originally stemmed from a desire of being consistent with the wayDataConverter
s are passed to Workflow Workers, where paths are required because these two converters need to be loaded inside the Workflow Sandbox.It however appears that in this specific case, consistency is often counter-productive. Workflow code and client code are often part of distinct deployment units, with distinct build processes for workflow vs client code, so that’s already inconsistent. By imposing consistency, we are forcing users to adapt and complexify the build process of all non-Workflow Worker components without no real reason to do so.
Instead, we should make
Client
accept pre-loaded data converters. And possibly do the same for Activity-only Workers.The text was updated successfully, but these errors were encountered: