Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up retry & long poll handling in retry client #813

Open
Sushisource opened this issue Sep 10, 2024 · 0 comments
Open

Clean up retry & long poll handling in retry client #813

Sushisource opened this issue Sep 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Sushisource
Copy link
Member

There's a handful of ways calls can be considered long polls in the client code, by name or by (recently added) request extension. Make everything use extension instead of explicit name checking, and make sure metrics are set consistently for all long poll types. Probably also lift the code that always retries timeouts/cancels for task polling from the client into the worker poller so it's not special cased in the client.

@Sushisource Sushisource added the enhancement New feature or request label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant