Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add temporal_worker_task_slots_total metric #392

Open
ghaskins opened this issue Dec 30, 2023 · 3 comments
Open

[Feature Request] Add temporal_worker_task_slots_total metric #392

ghaskins opened this issue Dec 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ghaskins
Copy link

Is your feature request related to a problem? Please describe.

It's harder to build meaningful visualizations on temporal_worker_task_slots_available alone when the total amount is unknown.

Most of the time, the graphs look like this

Screenshot 2023-12-30 at 9 00 12 AM

It's particularly hard to see nodes with smaller task slot allocations....and these are precisely the candidates likely to run into resource exhaustion.

Describe the solution you'd like

Providing a means to retrieve the total possible slots would make it trivial to graph the utilization percent using an 'available/total' approach. This would make it easier to observe the cases that require the most attention by better visual emphasis and alerting targets.

@ghaskins ghaskins added the enhancement New feature or request label Dec 30, 2023
@cretz
Copy link
Member

cretz commented Jan 3, 2024

when the total amount is unknown.

But since you set this value, it is known. You can expose this fixed value as a metric if you'd like.

@Quinn-With-Two-Ns
Copy link
Contributor

I think the SDK exposing this as a metric makes sense given these feature requests #334 #388

@ghaskins
Copy link
Author

ghaskins commented Jan 3, 2024

But since you set this value, it is known.

Well, it's known somewhere. But it's not conveniently accessible to metrics/dashboard consumers, making developing things like dashboards more fragile instead of generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants