Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug | Contract tab is not shown on address page #875

Closed
Viterbo opened this issue Nov 15, 2024 · 1 comment · Fixed by #876 or #877
Closed

Bug | Contract tab is not shown on address page #875

Viterbo opened this issue Nov 15, 2024 · 1 comment · Fixed by #876 or #877
Assignees
@Viterbo

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Nov 15, 2024 •
edited
Loading

Describe the bug
If you check the query about the contract info, you will notice that the contract exists, but the Contract tab is not shown for some reason.

To Reproduce

  1. Go to this address page
  2. See no Contract tab
  3. Open the console and see a possible related error: TypeError: Cannot read properties of undefined (reading 'hash')

Note: this issue may be related to #874

Screenshots
image
@Viterbo Viterbo mentioned this issue Nov 15, 2024
Open
@Viterbo Viterbo self-assigned this Nov 18, 2024
@Viterbo Viterbo mentioned this issue Nov 18, 2024
Merged
@Viterbo
Copy link
Collaborator Author

Viterbo commented Nov 18, 2024 •
edited
Loading

The problem source seems to be the indexer API, which is returning no transaction results for this address:
https://api.teloscan.io/v1/address/0xe0740E654B33550712E192c00C857D64Ce675Af3/transactions

In the front end, a new case was added to prevent the page from breaking in such situations (#876).
The contract Tab is still not shown and that should be fixed too

@Viterbo Viterbo linked a pull request Nov 18, 2024 that will close this issue
#875 | adding the case for no transaction history on address page #876
Merged
@Viterbo Viterbo mentioned this issue Nov 20, 2024
Merged
pmjanus added a commit that referenced this issue Nov 21, 2024
@pmjanus
Merge pull request #876 from telosnetwork/875-bug--contract-tab-is-no…
2098c7e 
…t-shown-on-address-page-1

#875 | adding the case for no transaction history on address page
@pmjanus pmjanus mentioned this issue Nov 21, 2024
Merged
pmjanus added a commit that referenced this issue Nov 21, 2024
@pmjanus
Merge pull request #880 from telosnetwork/875-bug--contract-tab-is-no…
6d0cd72 
…t-shown-on-address-page-2

#875 | bug - contract tab shown for factory-built contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Viterbo