Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the way we query the last internal transactions for an address #789

Closed
Viterbo opened this issue Jul 16, 2024 · 1 comment · Fixed by #877
Closed

Adapt the way we query the last internal transactions for an address #789

Viterbo opened this issue Jul 16, 2024 · 1 comment · Fixed by #877
Assignees

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Jul 16, 2024

Description

Currently, we fetch transactions one by one to get the last 20 internal transactions. This should be changed to query just one bulk list of the last internal transactions for an address.

Update:
This issue depends on https://github.com/telosnetwork/teloscan-indexer/issues/280

Uptade:

route will be /v1/address/{address}/internal?key=<determines-offset>

@Viterbo Viterbo self-assigned this Jul 16, 2024
@Viterbo Viterbo added 🚫 Blocked Work cannot be done until blocker is resolved and removed 🚫 Blocked Work cannot be done until blocker is resolved labels Jul 17, 2024
@Viterbo
Copy link
Collaborator Author

Viterbo commented Oct 24, 2024

we need to change the strategy on the query offset to what we use on the transaction page (using a p for the page and a key parameter on the query).

pmjanus added a commit that referenced this issue Nov 20, 2024
…the-last-internal-transactions-for-an-address

#789 | Fetch internal transactions from new API
@pmjanus pmjanus mentioned this issue Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant