Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use component from external package with dash-case tagname #900

Open
Julia-Alberici opened this issue Apr 5, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@Julia-Alberici
Copy link

use case:
Want to generate code to Angular flavour using components from the package @angular/material, the pattern of angular libs tagnames is dash-case, so i'm declaring a ProjectUIDL with this as one of the children page

{
    "type": "element",
    "content": {
        "elementType": "mat-autocomplete",
        "referencedStyles": {},
        "abilities": {},
        "children": [],
        "semanticType": "mat-autocomplete",
        "dependency": {
            "type": "package",
            "version": "latest",
            "path": "@angular/material",
            "meta": {
                "namedImport": true,
                "originalName": "MatAutocompleteModule"
            }
        }
    }
}

but the tagname will always end as camelCase bcz it has an external dependency.
I understand that for other flavours this behaviour makes sense, but it's broken to angular, shoudn't have a flag or something to fix this?

@JayaKrishnaNamburu
Copy link
Member

@Julia-Alberici thanks for reporting this. Yes, ideally we handle this behaviour for angular and vue flavour of code. I will take a look once 👍

@JayaKrishnaNamburu JayaKrishnaNamburu added the bug Something isn't working label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants