Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Node support for abilities in UIDL #535

Open
JayaKrishnaNamburu opened this issue Feb 3, 2021 · 0 comments
Open

Dynamic Node support for abilities in UIDL #535

JayaKrishnaNamburu opened this issue Feb 3, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@JayaKrishnaNamburu
Copy link
Member

Right now only 'url' ability can be a dynamic node.

We can send 'href' as a prop for a component from parent. Which is defined here

export const urlLinkNodeDecoder: Decoder<VUIDLURLLinkNode> = object({
  type: constant('url'),
  content: object({
    url: union(attributeValueDecoder, string()),
    newTab: boolean(),
  }),
})

But email phone etc are not dynamic.

cc @ionutpasca which fields would be a decent option, to have under ability that can be considered as dynamic.

@JayaKrishnaNamburu JayaKrishnaNamburu added the enhancement New feature or request label Feb 3, 2021
@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this Feb 3, 2021
@JayaKrishnaNamburu JayaKrishnaNamburu modified the milestone: 0.16 Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant