Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for options, that are passed for Component Generator's "Generate Options" #523

Open
JayaKrishnaNamburu opened this issue Dec 18, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JayaKrishnaNamburu
Copy link
Member

From the file, it says that component generator takes GenerateOptions which are GenerateOptions

export interface GenerateOptions {
  componentType?: ComponentType
  styleVariation?: StyleVariation
}

But with the introduction for project-style sheet, we need to pass the some global configurations too. Which are used for importing project-style sheet or referring to tokens etc. We currently do that from @teleporthq/teleport-code-generators here

We need to update the typescript types too to reflect the same.

@JayaKrishnaNamburu JayaKrishnaNamburu added the bug Something isn't working label Dec 18, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu added this to the 0.16 milestone Dec 18, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu changed the title Update types for options that are passed for Component Generator's "Generate Options" Update types for options, that are passed for Component Generator's "Generate Options" Dec 18, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu removed this from the 0.16 milestone Feb 3, 2021
@JayaKrishnaNamburu JayaKrishnaNamburu added this to the 0.17 milestone Mar 16, 2021
@JayaKrishnaNamburu JayaKrishnaNamburu added the good first issue Good for newcomers label Mar 16, 2021
@JayaKrishnaNamburu JayaKrishnaNamburu removed this from the 0.17 milestone Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant