Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue Styleguide #190

Open
alexnm opened this issue Apr 16, 2019 · 0 comments
Open

Vue Styleguide #190

alexnm opened this issue Apr 16, 2019 · 0 comments
Labels
enhancement New feature or request vue generators Issue related to the vue generator

Comments

@alexnm
Copy link
Contributor

alexnm commented Apr 16, 2019

I had a few discussions with some Vue experts (hello Bogdan Luca) and made a list of practices we should follow when generating Vue components. I'm leaving this here for now as research material, but this isn't an immediate issue to jump on, more like a reference we can keep for longer time. Perhaps we can move this to a separate .md file at some point

Links and ideas:

Vue behaviors to consider:

  • If you set a class to a custom component, it will get passed to the root element of the component, unlike in React when you need to explicitly send props.className
  • If a class is specified as a direct parent for a custom component, and that custom component has a root element with the same class name (ex: 'container'), the style from the parent component will also be applied (https://vue-loader.vuejs.org/guide/scoped-css.html#child-component-root-elements)
@alexnm alexnm added enhancement New feature or request vue generators Issue related to the vue generator labels Apr 16, 2019
@alexnm alexnm added this to the Official Release - v1.0 milestone Apr 16, 2019
@JayaKrishnaNamburu JayaKrishnaNamburu removed this from the Official Release milestone Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vue generators Issue related to the vue generator
Projects
None yet
Development

No branches or pull requests

2 participants