Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipeline matrix feature #1661

Open
afrittoli opened this issue Jul 28, 2022 · 4 comments
Open

Support pipeline matrix feature #1661

afrittoli opened this issue Jul 28, 2022 · 4 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@afrittoli
Copy link
Member

Feature request

Support all usual commands in case of tekton matrix.

Use case

Interact with Tekton pipelines that make use of matrix.

UI Example

I think the basic support would be make the logs command work. The current behaviour lists all tasks but the logs are only those of the first taskrun from the matrix.

$ tkn pr describe matrixed-pr-hl56m
Name:                  matrixed-pr-hl56m
Namespace:             default
Service Account:       default
Timeout(Deprecated):   1h0m0s
Labels:
 tekton.dev/pipeline=matrixed-pr-hl56m

🌡️  Status

STARTED         DURATION   STATUS
5 minutes ago   31s        Succeeded

🗂  Taskruns

 NAME                                               TASK NAME                    STARTED         DURATION   STATUS
 ∙ matrixed-pr-hl56m-platforms-and-browsers-dag-4   platforms-and-browsers-dag   5 minutes ago   7s         Succeeded
 ∙ matrixed-pr-hl56m-platforms-and-browsers-dag-5   platforms-and-browsers-dag   5 minutes ago   15s        Succeeded
 ∙ matrixed-pr-hl56m-platforms-and-browsers-dag-0   platforms-and-browsers-dag   5 minutes ago   10s        Succeeded
 ∙ matrixed-pr-hl56m-platforms-and-browsers-dag-1   platforms-and-browsers-dag   5 minutes ago   10s        Succeeded
 ∙ matrixed-pr-hl56m-platforms-and-browsers-dag-2   platforms-and-browsers-dag   5 minutes ago   11s        Succeeded
 ∙ matrixed-pr-hl56m-platforms-and-browsers-dag-3   platforms-and-browsers-dag   5 minutes ago   12s        Succeeded
 ∙ matrixed-pr-hl56m-get-platforms                  get-platforms                5 minutes ago   8s         Succeeded
 ∙ matrixed-pr-hl56m-get-browsers                   get-browsers                 5 minutes ago   15s        Succeeded

But in the logs:

$ tkn pr logs matrixed-pr-hl56m -f
[get-platforms : echo] linuxmacwindows

[get-browsers : echo] chromesafarifirefox

[platforms-and-browsers-dag : echo] windows and chrome

It might be nice to highlight the matrix better in the CLI view as well, for instance by visually grouping TaskRuns that belong to a matrix and which TaskRun is associated with this tuple of inputs.

@afrittoli afrittoli added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 28, 2022
@vdemeester vdemeester added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 29, 2022
@pradeepitm12 pradeepitm12 added this to the 0.27.0 milestone Sep 6, 2022
@piyush-garg piyush-garg modified the milestones: 0.27.0, 0.29.0 Nov 23, 2022
@piyush-garg piyush-garg modified the milestones: 0.29.0, 0.30.0 Jan 5, 2023
@vinamra28
Copy link
Member

/assign

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2023
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 26, 2023
@vdemeester
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 9, 2023
@vdemeester vdemeester added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 9, 2023
@piyush-garg piyush-garg modified the milestones: 0.32.0, 0.33.0 Aug 29, 2023
@piyush-garg piyush-garg modified the milestones: 0.33.0, 0.34.0 Nov 21, 2023
@vinamra28 vinamra28 modified the milestones: 0.34.0, v0.35.0 Jan 9, 2024
@piyush-garg piyush-garg modified the milestones: 0.35.0, 0.36.0 Feb 8, 2024
@piyush-garg piyush-garg modified the milestones: 0.36.0, 0.37.0, 0.38.0 May 8, 2024
@piyush-garg piyush-garg modified the milestones: 0.38.0, 0.39.0 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: Todo
Development

No branches or pull requests

6 participants