Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate linting resources and the catalog "layout" #18

Open
vdemeester opened this issue Nov 27, 2023 · 0 comments
Open

Separate linting resources and the catalog "layout" #18

vdemeester opened this issue Nov 27, 2023 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vdemeester
Copy link
Member

As of today, lintking a tekton resource in a yaml file, not in a catalog, will fail saying the resource path is wrong.

FILE: ../tmp/task/go-ko-image/go-ko-image.yaml
ERROR: Resource path is invalid; expected path: task/go-ko-image/0.2.1/go-ko-image.yaml

It shouldn't be the case. We should be able to validate the layout of a catalog (task/{name}/{version}/…) and the content of the file independently.

It could be 2 different commands catlin validate-resource path/to/file and catlin validate-catalog path/to/catalog.
@vdemeester vdemeester added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2023
vdemeester added a commit to vdemeester/task-openshift that referenced this issue Nov 28, 2023
@vdemeester
Make lint happy even if catlin fails…
7005377 
… for now. The main reason is that not all is fixable directly.
See for example tektoncd/catlin#18

Signed-off-by: Vincent Demeester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vdemeester