Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v1 Types #10

Open
vdemeester opened this issue Feb 22, 2023 · 5 comments
Open

Add support for v1 Types #10

vdemeester opened this issue Feb 22, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vdemeester
Copy link
Member

Feature request

tektoncd/pipeline now ships with a v1 API. Catlin should support validating them.

Use case

Support the newest api version (and the stable / ga version)

@vdemeester vdemeester added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 22, 2023
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@vdemeester
Copy link
Member Author

/lifecycle frozen

@kmontg
Copy link
Contributor

kmontg commented Jan 16, 2024

I'm happy to add this if there are any pointers on what's needed.

@austinzhao-go
Copy link

thank you @vdemeester for raising this issue.

did some exploration on the code base and related v1 docs..

  • mainly the script.go, parse.go, and task_validator.go are coded with the v1beta1 objects, like *.Task or *.Step.
  • tried to flip the version as v1, the current unit tests pass still because there is no diff for validated parts of the fields between the 2 versions, like script or img. (I referred here https://github.com/tektoncd/pipeline/blob/main/docs/migrating-v1beta1-to-v1.md)
  • one exception is parser.go - there are *.Task and *.ClusterTask. as I checked the current pipeline configs, the *.ClusterTask is only on v1beta1.

thinking likely we need to support validations for both versions, I should not just flip the version in the code. perhaps we need to implement and structure the code, somehow like the pipeline https://github.com/tektoncd/pipeline/tree/main/pkg/apis/pipeline - so diff folders for the v1 and v1beta1 versions...
also, we might need to implement new rules for the updated v1 api.

some initial thoughts, how about your ideas?

@austinzhao-go
Copy link

hi @vdemeester, wave my hands here ;)

any more contexts perhaps we could have here. we are trying to update the v1beta1 reference to v1, but met the question likely we will still need to support the v1beta1. also we are not quite sure what will be validation rules updated here between the 2 versions.

loop @arifash01 in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants