Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in the testcloud plugin #3235

Closed
psss opened this issue Sep 23, 2024 · 2 comments · Fixed by #3266
Closed

Race condition in the testcloud plugin #3235

psss opened this issue Sep 23, 2024 · 2 comments · Fixed by #3266
Assignees
@frantisekz
Labels
plugin | testcloud The testcloud virtual provision plugin priority | should medium priority, should be included in the next release step | provision Stuff related to the provision step
Milestone
1.38

Comments

@psss
Copy link
Collaborator

psss commented Sep 23, 2024

Based on the recent results of the /plans/provision/virtual/* plans it seems the race condition is still there. Multihost tests quite frequently fail with:

Failed to connect in 300s.

@frantisekz, in #3036 you've mentioned that the change opens way to address the problem in an atomic way. Would you have some time to look into this?
@psss psss added step | provision Stuff related to the provision step plugin | testcloud The testcloud virtual provision plugin priority | should medium priority, should be included in the next release labels Sep 23, 2024
@psss
Copy link
Collaborator Author

psss commented Sep 23, 2024

Here's a recent example job with the full log details.

@frantisekz frantisekz self-assigned this Sep 23, 2024
@frantisekz
Copy link
Collaborator

Yeah, I had it upstream for some time: https://pagure.io/testcloud/c/6da8ed8c96e3f748f8c242dc168b45017be251f5?branch=master

I can bake out copr build at least if that'd help with testing? Release is currently held by https://pagure.io/testcloud/issue/191 from rewritten image code, I'll poke some more there to get that resolved.

@psss psss added this to the 1.38 milestone Sep 24, 2024
@psss psss linked a pull request Sep 26, 2024 that will close this issue
Require the latest testcloud with the race fix #3244
Closed
@frantisekz frantisekz mentioned this issue Oct 7, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frantisekz frantisekz

Labels
plugin | testcloud The testcloud virtual provision plugin priority | should medium priority, should be included in the next release step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.38
2 participants
@frantisekz @psss