Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging for nested dictionaries defined in root #190

Open
lukaszachy opened this issue Apr 26, 2023 · 2 comments
Open

Merging for nested dictionaries defined in root #190

lukaszachy opened this issue Apr 26, 2023 · 2 comments
Labels
Milestone

Comments

@lukaszachy
Copy link
Collaborator

Based on the promises of Elasticity and Merging I'd expect this fmf file (either main.fmf or arbitrary name in the fmf root)

a+:
  b+:
    c: d

to produce 'a': {'b': {'c': 'd'} dictionary. However currently 'a+' and 'b+' is kept as key names.

Also the

foo: bar

/child:
    a+:
        b+:
            c: d

keeps 'b+' as key name (the 'a' is correctly named.)

Would be nice if one can use Merging everywhere in the Tree structure.

@lukaszachy lukaszachy added this to the 1.3 milestone Apr 26, 2023
@jscotka
Copy link
Collaborator

jscotka commented Jul 28, 2023

Should work well as we've introduced. Probably some feature break this behaviour. I remember I've implemented it in #93

@psss psss modified the milestones: 1.3, 1.4 Sep 29, 2023
@psss psss modified the milestones: 1.4, 1.5 Apr 16, 2024
@kkaarreell
Copy link

Should work well as we've introduced. Probably some feature break this behaviour. I remember I've implemented it in #93

Your test is still working, however the major difference here is that in your test the non-plus attribute exists while in the example above there is no a attribute to extend.

What works is:

$ cat main.fmf
a: {}

/child:
    a+:
        b+:
            c: d

$ fmf show
/child
a: {'b': {'c': 'd'}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants