Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations across large numbers of objects, create performance issues #1

Open
kirkbushell opened this issue Jun 18, 2015 · 3 comments
Milestone

Comments

@kirkbushell
Copy link
Member

Due to the nature of converting eloquent model objects to translated entities and collections, it's currently quite an expensive operation (in PHP) to do this, as well as providing all translated values.

This is both an open discussion and issue to help generate a dialog of how best to approach this problem whilst maintaining the SQL performance that this package provides (all translations for all nested objects are done in one query).

This may possible include some API changes, which is why the issue is marked for version 2.0.

@kirkbushell kirkbushell added this to the 2.0 milestone Jun 18, 2015
@kirkbushell
Copy link
Member Author

@valorin feel free to contribute here, as well - as your input and knowledge is quite in-depth regarding the package :)

@kirkbushell
Copy link
Member Author

I think as a starting point, the base repository probably shouldn't use eloquent objects, but rather do a straight db query and work with stdClasses. In this manner, the number of expensive objects will be vastly reduced, as it doesn't need to do all the hydration work.

@kirkbushell
Copy link
Member Author

This may have been resolved (at least in part), by #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant