Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to map the color "magenta" #19

Open
nemethf opened this issue Oct 8, 2024 · 2 comments
Open

Fails to map the color "magenta" #19

nemethf opened this issue Oct 8, 2024 · 2 comments

Comments

@nemethf
Copy link

nemethf commented Oct 8, 2024

Let's have a buffer with the content of /tmp/a.sh :

#!/bin/bash
echo $(date)

Here M-x engrave-faces-latex-buffer results in:

\color{EFD}\EFcd{\#}\EFc{!/bin/}\EFk{bash}
\EFb{echo} \$(\textcolor[HTML]{agenta}{date})

Note the missing "m" in the color name "agenta". The tex command should be something like \textcolor{magenta}{date}.

To reproduce the issue, it is enough to start from:

emacs -Q \
  -l ~/.emacs.d/elpa/engrave-faces-0.3.1/engrave-faces.elc \
  -l ~/.emacs.d/elpa/engrave-faces-0.3.1/engrave-faces-latex.elc \
  -l cl-extra \
  /tmp/a.sh

This is with "GNU Emacs 28.2" and "GNU Emacs 31.0.50".

Thanks.

@tecosaur
Copy link
Owner

That's a funky issue! Thanks for raising this, I'll try to reproduce it when I get a few moments spare.

@nemethf
Copy link
Author

nemethf commented Oct 26, 2024

C-u C-x = on "date" shows that it has a face property of sh-quoted-exec, which is not in the default
engrave-face-themes. The latest release of engrave-face handles this situation poorly as the original
bug report demonstrated. However, it seems commit e541cf4 fixed this issue.

Would it be possible to push a new version containing this fix to GNU ELPA? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants