Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a dataset programmatically prompts for input #23

Open
jfb-h opened this issue Feb 18, 2024 · 3 comments
Open

Adding a dataset programmatically prompts for input #23

jfb-h opened this issue Feb 18, 2024 · 3 comments
Labels
question Further information is requested

Comments

@jfb-h
Copy link
Contributor

jfb-h commented Feb 18, 2024

Adding a dataset via

DataToolkitBase.add(DataToolkit.Dataset, name, Dict{String, Any}("description" => description), source)

still prompts for user input on description and attributes, which is probably not intended?

Btw., is spec::Dict{String, Any} the right place to put description info?

@tecosaur
Copy link
Owner

Yea, the DataToolkitBase "julia API" probably needs a bit more love that I've been able to give it so far.

It should definitely be able to operate noninteractively, and to answer your question spec is indeed the right place to put a description.

@tecosaur tecosaur transferred this issue from tecosaur/DataToolkit.jl Feb 20, 2024
@tecosaur
Copy link
Owner

tecosaur commented Apr 7, 2024

On this topic, if anybody has ideas for a nice Julia API and a willingness to dig into the codebase, I'd love to hear them.

@tecosaur tecosaur added the question Further information is requested label May 16, 2024
@tecosaur tecosaur transferred this issue from tecosaur/DataToolkitCore.jl May 29, 2024
@tecosaur
Copy link
Owner

tecosaur commented Jun 16, 2024

I'm currently overhauling this, so interactive input is gated behind the (new) REPL package.

Here's what the WIP-API looks like:

collection = DataCollection()
dataset = create!(collection, DataSet, "name", "description" => desc, ...)
create!(dataset, DataStorage, :filesystem, "path" => "path/to/file.csv")
create!(dataset, DataLoader, :csv)

I'm wondering if for convenience it might also be worth having

collection = DataCollection()
dataset!(collection, "name", "description" => desc, ...)
storage!(dataset, :filesystem, "path" => "path/to/file.csv")
loader!(dataset, :csv)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants