Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken reference to metallb-webhook-service and invalid APT source for Ubuntu 24.04 LTS on arm64 #543

Closed
winzlocom opened this issue Jul 16, 2024 · 5 comments

Comments

@winzlocom
Copy link

I'd like to offer a fix/patch to the current master which accomplishess two things:

  1. Fixes an improper reference to metallb-webhook-service, which caused the deploy.sh to fail
  2. Remove the kernel module involvement for Ubuntu 24.04 LTS on ARM64 (Raspberry PI) as it does not exist in the APT sources.

diff --git a/roles/k3s_server_post/tasks/metallb.yml b/roles/k3s_server_post/tasks/metallb.yml
index 07a23b0..363f4c3 100644
--- a/roles/k3s_server_post/tasks/metallb.yml
+++ b/roles/k3s_server_post/tasks/metallb.yml
@@ -85,7 +85,7 @@

  • name: Test metallb-system webhook-service endpoint
    command: >-
  • k3s kubectl -n metallb-system get endpoints webhook-service
  • k3s kubectl -n metallb-system get endpoints metallb-webhook-service
    changed_when: false
    with_items: "{{ groups[group_name_master | default('master')] }}"
    run_once: true
    diff --git a/roles/raspberrypi/tasks/setup/Ubuntu.yml b/roles/raspberrypi/tasks/setup/Ubuntu.yml
    index 72c77c9..93d55b9 100644
    --- a/roles/raspberrypi/tasks/setup/Ubuntu.yml
    +++ b/roles/raspberrypi/tasks/setup/Ubuntu.yml
    @@ -7,7 +7,7 @@
    line: '\1 cgroup_enable=cpuset cgroup_memory=1 cgroup_enable=memory'
    notify: reboot

-- name: Install linux-modules-extra-raspi

  • apt:
  • name: linux-modules-extra-raspi
  • state: present
    +#- name: Install linux-modules-extra-raspi
    +# apt:
    +# name: linux-modules-extra-raspi
    +# state: present
@timothystewart6
Copy link
Contributor

PR is welcome!

@timothystewart6
Copy link
Contributor

We'll also need to be sure we can test this in CI with the Ubuntu 24.04 image. That will need to be added to the PR as well.

@yebo29
Copy link
Contributor

yebo29 commented Aug 28, 2024

Can confirm that the fix for the metallb endpoint fixed the issue for me. My playbook runs were failing on that task. I can create a PR at some point today for that.

@yebo29
Copy link
Contributor

yebo29 commented Aug 28, 2024

Never mind. It seems it was fixed already

@timothystewart6
Copy link
Contributor

fixed by #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants