Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Concurrency GHA Feature to CI #386

Closed
timothystewart6 opened this issue Oct 25, 2023 · 1 comment
Closed

Add Concurrency GHA Feature to CI #386

timothystewart6 opened this issue Oct 25, 2023 · 1 comment
Labels
CI Related to continuous integration and testing

Comments

@timothystewart6
Copy link
Contributor

CI fails a lot, most of it is because the nature of our machines but some of it might be due to concurrency.

We might want to limit concurrency using this https://docs.github.com/en/actions/using-jobs/using-concurrency

  • This will prevent new workflows from running until previous have completed.
  • This will help when PRs are opened by a person or the bot
  • This will help when someone pushes more commits to their branch

We might also want to consider running the individual jobs serially, rather than in parallel.

  • This would only allow one job to run at a time

The upside is that this might help with build failures
The downside is that builds will take loner (but when they fail we have to manually intervene which takes the longest)

@timothystewart6 timothystewart6 added the CI Related to continuous integration and testing label Oct 25, 2023
@timothystewart6 timothystewart6 changed the title Add Concurrency to CI Add Concurrency GHA Feature to CI Oct 25, 2023
@timothystewart6 timothystewart6 mentioned this issue Oct 29, 2023
6 tasks
@timothystewart6
Copy link
Contributor Author

this was fixed by #389.

we don't need concurrency now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to continuous integration and testing
Projects
None yet
Development

No branches or pull requests

1 participant