guacamole_connection_ssh -> terminal_type -> xterm-25color is bad value

[ArnaultMICHEL]

Hi

I found a potential little mistake on a value checked for guacamole_connection_ssh -> terminal_type : xterm-25color

• it should be xterm-256color

• CLI htop is not working properly as it use $TERM env var

Terraform Version

Terraform v1.4.5
on linux_amd64

Guacamole provider version

techbeck03/guacamole v1.4.1

Affected Resource

• guacamole_connection_ssh

Terraform Configuration Files

resource "guacamole_connection_ssh" "conn_ssh" {
  ...
  parameters {
    ..
    terminal_type = "xterm-25color"
  }
}

Expected Behavior

allow xterm-256color value instead of xterm-25color for terminal_type parameter

Actual Behavior

terraform apply is OK, but the $TERM is not correct for some linux CLI tools

arnault.michel@test-host:~$ htop                      
Error opening terminal: xterm-25color.
arnault.michel@test-host:~$ echo $TERM                
xterm-25color

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply
2. open the SSH connection to the linux VM
3. launch htop

References

please change the documentation

[Thomas-McKanna]

This is definitely a bug. Even in the Gucacamole UI, you can see it should be xterm-256color. Unfortunately, this bug means that xterm-256color cannot be set with this Terraform provider, since the incorrect value seems to be simply ignored by Guacamole (so terminal type ends up being set to nothing).

[Thomas-McKanna]

Opened #16 to fix this. It is really straightforward.

[techBeck03]

Thanks, I’ll work on applying the fix

…

On Fri, Nov 29, 2024 at 2:28 PM Thomas McKanna ***@***.***> wrote: Opened #16 <#16> to fix this. It is really straightforward. — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXY3EZGXYESUJZ7O4LCEX32DDE77AVCNFSM6AAAAABSXWLTCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYGYYTGNJSGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.*** com>