Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] modal appears and overlaps screen if parentElement is gone #224

Open
woutersteven opened this issue Sep 15, 2023 · 1 comment
Open
Assignees
Labels
feature New feature or request

Comments

@woutersteven
Copy link

Describe the bug
Perhaps not really a bug, but would suggest a console log for troubleshooting.

If you have an Ionic Tabs app, and append the pane to a custom element inside the tabs at the bottom, for example

<div class="cupertino-append" style="z-index: 1000 !important;"></div>

Then navigating to another component (that's not part of the tabs) and then navigating back using the back button of your browser, will show the modal open and unable to be dismissed, because the parentElement is gone. But the modal remains overlapping the rest of the page.

I realize this is an edge case and doesn't affect people that append to body or ion-content. In my case I also attached it to an element that won't disappear, regardless of the tab routing. But it would be helpful if it could somehow be caught in the console... not sure if thats possible.

@roman-rr
Copy link
Collaborator

Related to #233, you might pass it to some global vars, singleton, or window object.
But good to make panes accessible from window object from pane core as well.

@roman-rr roman-rr self-assigned this Sep 19, 2023
@roman-rr roman-rr added the feature New feature or request label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants