Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apptypes_e2e job needs updating (helmc -> helm) #9

Open
Cryptophobia opened this issue Mar 22, 2018 · 0 comments
Open

apptypes_e2e job needs updating (helmc -> helm) #9

Cryptophobia opened this issue Mar 22, 2018 · 0 comments

Comments

@Cryptophobia
Copy link
Member

From @vdice on January 11, 2017 21:49

https://github.com/deis/jenkins-jobs/blob/master/jobs/apptypes_test.groovy needs updating. Still setup to use helm-classic where env vars could be detected for manifest generation. To update to helm use, we would need to pass this env var in via helm ... --set test=bps (see https://github.com/deis/workflow-e2e/blob/master/charts/workflow-e2e/values.yaml#L7).

In practice, the change to the job DSL here may be nil/minimal and actual logic to check the env and perform step as mentioned above to be added in deis/e2e-runner

Copied from original issue: deis/jenkins-jobs#322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant