-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go mod init #73
base: master
Are you sure you want to change the base?
Go mod init #73
Conversation
Welp, the issue I was having turned out to be a completely different reason (it helps if you believe the error message when you are reading it and it tells you what the problem is) – my git remote was wrong, which should have been the first thing I had guessed, as it was the last thing I had changed! No matter, it was time to do these upgrades anyway. I found a storage issue caused by this change:
The error was
Either caused by something I changed, or by simply building again, (but as I could not get this to build anymore without changes I basically had no choice but to make them all.) It works without glide now, at least it seems that way! But there are storage issues, my backend is minio and this new canary release of builder that I'm running is the only thing that changed. I'll work it out, then rebase, clean up my commit messages, and see you on the other side of 2021... 🎉 🌮 |
I could not get this to `make bootstrap` without these changes Also, update hephy/go-dev image reference in Makefile to latest hephy 1.33.3 (which appears to have removed glide!)
I have no idea if this is a proper go.mod but it builds, runs ok with go mod tidy, and the tests are all passing now
a3cb9b2
to
488814f
Compare
This is still broken (setting as draft so it does not get merged yet) |
It looks like the meaning of We do keep files with a colon in the path. We could pretty easily stop doing that, but it would make a lot of older storage inaccessible to accept this change from upstream. (I don't see how we have a choice, but maybe there's an adapter we can include so we don't have to make a permanently new storage epoch and tell everyone about a breaking change, as this will otherwise break rollbacks for everyone...) |
It looks like upgrading to the latest hephy/go-dev image means upgrading to go 1.16, which means using go mod instead of glide, so I went ahead and did that, I think it works 🤞
I will rebase and amend these commits to have proper messages in a bit, I am just trying to get a working builder image out of this right now, since I think there are some mandatory upgrades that we are missing, (and it impacts updates to the Hephy blog, which uses builder buildpacks to deploy Jekyll on Ruby processes)