-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add (overridable) support for page titles #197
Comments
Sounds good to me :D |
I've been looking into this. It appears that |
What is |
Typo, should be |
Yeah I'm not sure what that page is for. Maybe an artifact? @jimsynz |
@zachdaniel @ArthurClemens It's the page that a user arrives on when they click the password reset link (in their email, for example) route is: |
|
I figured so much after spending some time on SignInLive. The problem I see is that the configuration options don't allow for different headings, info texts and page_title for the scenarios "sign in", "register", "reset password", where sign in and register can have variants for email/password and oauth. There will be other wishes for with pages, and at some point it makes sense to create custom templates, but I think that ash_authentication can do more in bridging that gap. I've created a list of elements that I think make sense (based on UX work I did on a previous project) - and I'm sure I am missing a few due to the many configurable options. "Pages"
Common page elementsThese will likely differ per page, which means that ideally each of the pages above should be supported by configurable options.
|
There is relevant discussion in #236 you may want to share some of this there. |
It would be great to add page titles to the authentication routes, e.g.
Ideally, these would be configurable via the override system.
If this sounds like a good idea, I'd be willing to work up a PR implementing it.
The text was updated successfully, but these errors were encountered: