Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security implications of #66 #70

Open
2 tasks
luckydonald opened this issue Sep 26, 2021 · 1 comment
Open
2 tasks

Security implications of #66 #70

luckydonald opened this issue Sep 26, 2021 · 1 comment

Comments

@luckydonald
Copy link
Collaborator

luckydonald commented Sep 26, 2021

With #66 merged, I still have a few points I think we still need to address, and at least document:

I think for security reasons this one would be a quite high priority to solve:

  • How can the configuration of that be turned off for the public instances we host?

Additionally it would make sense to write

  • A section about proxy support, listing the available methods in the README.

Would be nice for those not looking at the changelog too closely.

@davidgfnet
Copy link

Right, it would be good to add a commandline argument to enable/disable this. I agree that it might be good to have it "disabled by default" unless explicitly enabled :/
Will send a PR to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants