Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styles for RTL languages #1

Open
hosseinn opened this issue Mar 21, 2012 · 2 comments
Open

Fix styles for RTL languages #1

hosseinn opened this issue Mar 21, 2012 · 2 comments

Comments

@hosseinn
Copy link

CSS styles does not work well for RTL languages. For example, paddings are tailored for LTR languages and does not show well for languages like Persian and Arabic.
See:
http://fa.libreoffice.org/download/
and compare it to the with the fixed CSS:
http://libreoffice.ir/blog/wp-content/uploads/2012/03/download-libre.jpg
Unfortunately some parts of the CSS are hardcoded within HTML.

@cloph
Copy link
Member

cloph commented Jun 27, 2012

was waiting for the fixed css or a pull request and then I forgot about this issue - so when you already prepared a fixed version to make that screenshot - where did you post the necessary changes?

@hosseinn
Copy link
Author

I didn't have SilverStripe installed, so I changed the CSS "inline" using Firebug. Actually, a lot of tailoring is needed for RTL languges, for example images should be mirrored. But for a quick fix, just remove this line from "typography.css", line 114.

background-position: right 6px;

It will fix the problem of not showing the download icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants