Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Implement Extractor and Finalizer roles #16

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Commits on Jan 22, 2024

  1. v0: Comment incomplete extractor

    The current v0 extractor code only works for the happy path, it does not
    do checks on the input PSBT as specified by the bip.
    
    Add a TODO and also copy the relevant text from bip-174.
    tcharding committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c2b8493 View commit details
    Browse the repository at this point in the history
  2. v2: Remove non-built miniscript code

    This code was just cut'n'paste and isn't currently being built. Just
    delete it and we will start from scratch.
    tcharding committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    950307c View commit details
    Browse the repository at this point in the history
  3. v2: Add funding methods to InputBuilder

    Add two methods to the `InputBuilder` to add funding utxos. Note that it
    would really be better to use the type system to enforce existence of
    the funding utxo but doing so would take us away from `Input` being a
    1-1 representation of the bip.
    tcharding committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4295d7a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. v2: Add Finalizer and Extractor Roles

    Add types for the two new roles. Feature gate the `Finalizer` on
    "miniscript". Because another entity may be the Finalizer do not feature
    gate the `Extractor` oven thought transaction extraction is only
    possible for a finalized PSBT.
    tcharding committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    54fa5da View commit details
    Browse the repository at this point in the history