Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] action icons in Git view are too dark when selected #23

Open
tennox opened this issue Jun 22, 2022 · 2 comments
Open

[BUG] action icons in Git view are too dark when selected #23

tennox opened this issue Jun 22, 2022 · 2 comments
Assignees
@tcd
Labels
bug planned on the roadmap; expect this to get done

Comments

@tennox
Copy link

tennox commented Jun 22, 2022

Bug

image

Describe the bug

I'm using the light-plus-syntax (high contrast) theme

In source control view, when clicking a file, the icons don't change to white.

This does actually happen in the upstream (I guess it's upstream) Light+

Relevant Information

VSCode

  • Track: VSCodium (standard)
  • Version: Version: 1.68.1 (Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630)
    Date: 2022-06-16T00:18:08.407Z
    Electron: 17.4.7
    Chromium: 98.0.4758.141
    Node.js: 16.13.0
    V8: 9.8.177.13-electron.0
    OS: Linux x64 5.18.5-200.fc36.x86_64
  • Extensions: dunstontc.dark-plus-syntax v0.2.8
@tennox tennox added the bug label Jun 22, 2022
@tcd
Copy link
Owner

tcd commented Oct 13, 2022 •
edited
Loading

@tennox Agreed. Plan on fixing it.
Pushing out some changes to day; will try to address this (most likely in v0.2.10)

@tcd tcd added the planned on the roadmap; expect this to get done label Oct 13, 2022
@tcd
Copy link
Owner

tcd commented Oct 18, 2022

@tennox Addressed the issue in v0.2.11:

image

I noted in the changelog that I'm going to review ui/general colors for all themes soon to weed out any more issues like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcd tcd

Labels
bug planned on the roadmap; expect this to get done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tennox @tcd