Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure getWeekInfo will not not listen to 'rg' #85

Open
FrankYFTang opened this issue Jul 18, 2024 · 4 comments
Open

Ensure getWeekInfo will not not listen to 'rg' #85

FrankYFTang opened this issue Jul 18, 2024 · 4 comments

Comments

@FrankYFTang
Copy link
Collaborator

This is an issue fork out from @anba's comment in the review of
#83

During 2024-07-18, TG2 believe the patch @anba suggested has other undesireable side effect, such as "fr-u-ca-hebrew" may not return the right result .

What @anba suggest is

-        1. Let _r_ be a record whose fields are defined by <emu-xref href="#table-locale-weekinfo-record"></emu-xref>, with values based on _locale_.
+        1. Let _languageId_ be the longest prefix of _locale_ matched by the <code>unicode_language_id</code> Unicode locale nonterminal.
 +       1. Let _r_ be a record whose fields are defined by <emu-xref href="#table-locale-weekinfo-record"></emu-xref>, with values based on _languageId_.

but that remove not just 'rg' but also 'ca'

The question is how should we address the issue that we want to make sure right now we will not listen to 'rg' but will still respect to 'ca'.

@sffc

@FrankYFTang
Copy link
Collaborator Author

Regarding should the calendar value in -u-ca- beside iso8601 impact the first day of week. I filed a CLDR ticket at https://unicode-org.atlassian.net/browse/CLDR-17819

@sffc
Copy link
Contributor

sffc commented Jul 19, 2024

According to UTS 35, https://unicode.org/reports/tr35/tr35-dates.html#first-day-overrides, which was added as part of https://unicode-org.atlassian.net/browse/CLDR-16866, -u-ca can impact the first day of week, in the following order:

  1. -u-fw
  2. -u-rg
  3. -u-ca
  4. region
  5. -u-sd

And there is also https://unicode-org.atlassian.net/browse/CLDR-17151 to promote the -u-sd to be higher up.

@FrankYFTang
Copy link
Collaborator Author

FrankYFTang commented Jul 30, 2024

The first day of week will respect rg after ICU75 (see unicode-org/icu#2711 ) currently v8 is still on 74.2

@FrankYFTang
Copy link
Collaborator Author

be aware of unicode-org/cldr#4049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants