Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ fix alpha order of terms, add script to detect problems and output all terms in alpha order #115

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# EditorConfig helps developers define and maintain consistent
ljharb marked this conversation as resolved.
Show resolved Hide resolved
# coding styles between different editors and IDEs
# editorconfig.org

root = true


[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = space
indent_size = 2
213 changes: 213 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,213 @@
module.exports = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to hardcode everything here, instead of basing it on a popular common shared config?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just copying my boilerplate opinionated config. I'm fine with changing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd personally prefer something minimal, and static, and largely based on something commonly used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just don't bother. There's a bunch of scripts in ecma262 and those aren't linted. Since they're almost never touched it doesn't really matter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also a viable choice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 nuked the rules block

root: true,
env: {
browser: false,
node: true,
es2022: true
},
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
ecmaFeatures: {
impliedStrict: true
}
},
extends: ['eslint:recommended'],
globals: {
},
rules: {

// ERRORS
'for-direction': 'error',
'getter-return': 'error',
'no-await-in-loop': 'error',
'no-extra-parens': 'error',
'no-prototype-builtins': 'error',
'no-template-curly-in-string': 'error',

// BEST PRACTICES
'accessor-pairs': 'error',
'array-callback-return': 'error',
'class-methods-use-this': 'error',
'complexity': ['error', 10],
'consistent-return': 'error',
'curly': 'error',
'default-case': 'error',
'dot-location': ['error', 'property'],
'dot-notation': 'error',
'eqeqeq': 'error',
'guard-for-in': 'error',
'no-alert': 'error',
'no-caller': 'error',
'no-div-regex': 'error',
'no-else-return': 'error',
'no-empty-function': 'error',
'no-eq-null': 'error',
'no-eval': 'error',
'no-extend-native': 'error',
'no-extra-bind': 'error',
'no-extra-label': 'error',
'no-floating-decimal': 'error',
'no-implicit-coercion': 'error',
'no-implicit-globals': 'error',
'no-implied-eval': 'error',
'no-iterator': 'error',
'no-labels': 'error',
'no-lone-blocks': 'error',
'no-loop-func': 'error',
'no-multi-spaces': 'error',
'no-multi-str': 'error',
'no-new': 'error',
'no-new-func': 'error',
'no-new-wrappers': 'error',
'no-octal-escape': 'error',
'no-param-reassign': 'error',
'no-proto': 'error',
'no-return-assign': 'error',
'no-return-await': 'error',
'no-script-url': 'error',
'no-self-compare': 'error',
'no-sequences': 'error',
'no-throw-literal': 'error',
'no-unmodified-loop-condition': 'error',
'no-unused-expressions': 'error',
'no-useless-call': 'error',
'no-useless-concat': 'error',
'no-useless-return': 'error',
'no-void': 'error',
'no-warning-comments': ['warn', { 'terms': ['fix', 'fixme', 'todo', 'to do', 'hack'], 'location': 'anywhere' }],
'no-with': 'error',
'prefer-promise-reject-errors': ['error', { 'allowEmptyReject': true }],
'require-await': 'error',
'vars-on-top': 'error',
'wrap-iife': 'error',
'yoda': 'error',

// VARIABLES
'no-shadow': 'error',
'no-shadow-restricted-names': 'error',
'no-undef-init': 'error',
'no-undefined': 'error',
'no-use-before-define': ['error', { 'functions': false }],

// NODE
'callback-return': 'error',
'global-require': 'error',
'handle-callback-err': 'error',
'no-buffer-constructor': 'error',
'no-mixed-requires': 'error',
'no-new-require': 'error',
'no-path-concat': 'error',
'no-process-env': 'error',
'no-process-exit': 'error',

// STYLE
'array-bracket-newline': ['error', { 'multiline': true }],
'array-bracket-spacing': 'error',
'block-spacing': 'error',
'brace-style': ['error', 'stroustrup', { 'allowSingleLine': true }],
'camelcase': 'error',
'comma-spacing': 'error',
'comma-style': 'error',
'computed-property-spacing': 'error',
'consistent-this': ['error', 'self'],
'eol-last': 'error',
'func-call-spacing': 'error',
'func-name-matching': 'error',
'func-names': ['error', 'never'],
'func-style': ['error', 'declaration', { 'allowArrowFunctions': true }],
'indent': ['error', 2, { 'SwitchCase': 1 }],
'key-spacing': 'error',
'keyword-spacing': 'error',
'linebreak-style': 'error',
'lines-around-comment': 'error',
'max-depth': 'error',
'max-lines': 'error',
'max-nested-callbacks': ['error', 4],
'max-params': ['error', 6],
'max-statements': ['error', 99],
'max-statements-per-line': ['error', { 'max': 2 }],
'multiline-ternary': ['error', 'always-multiline'],
'new-cap': 'error',
'new-parens': 'error',
'no-array-constructor': 'error',
'no-bitwise': 'error',
'no-continue': 'error',
'no-lonely-if': 'error',
'no-mixed-operators': 'error',
'no-multi-assign': 'error',
'no-multiple-empty-lines': ['error', { 'max': 1, 'maxEOF': 1, 'maxBOF': 0 }],
'no-negated-condition': 'error',
'no-nested-ternary': 'error',
'no-new-object': 'error',
'no-plusplus': ['error', { 'allowForLoopAfterthoughts': true }],
'no-tabs': 'error',
'no-trailing-spaces': 'error',
'no-underscore-dangle': 'error',
'no-unneeded-ternary': 'error',
'no-whitespace-before-property': 'error',
'object-curly-newline': ['error', { 'consistent': true }],
'object-curly-spacing': ['error', 'always'],
'object-property-newline': ['error', { 'allowMultiplePropertiesPerLine': true }],
'one-var': ['error', { 'initialized': 'never', 'uninitialized': 'always' }],
'operator-assignment': 'error',
'operator-linebreak': ['error', 'after'],
'padding-line-between-statements': [
'error',
{ 'blankLine': 'always', 'prev': 'import', 'next': '*' },
{ 'blankLine': 'never', 'prev': 'import', 'next': 'import' },
{ 'blankLine': 'always', 'prev': 'class', 'next': '*' },
{ 'blankLine': 'always', 'prev': '*', 'next': 'class' },
{ 'blankLine': 'always', 'prev': 'block', 'next': '*' },
{ 'blankLine': 'always', 'prev': '*', 'next': 'block' },
{ 'blankLine': 'always', 'prev': 'block-like', 'next': '*' },
{ 'blankLine': 'always', 'prev': '*', 'next': 'block-like' },
{ 'blankLine': 'always', 'prev': 'cjs-export', 'next': '*' },
{ 'blankLine': 'always', 'prev': '*', 'next': 'cjs-export' },
{ 'blankLine': 'always', 'prev': 'cjs-import', 'next': '*' },
{ 'blankLine': 'never', 'prev': 'cjs-import', 'next': 'cjs-import' },
{ 'blankLine': 'always', 'prev': 'let', 'next': 'const' },
{ 'blankLine': 'always', 'prev': 'const', 'next': 'let' },
{ 'blankLine': 'never', 'prev': 'let', 'next': 'let' }
],
'quotes': ['error', 'single', { 'allowTemplateLiterals': true }],
'semi': 'error',
'semi-spacing': 'error',
'semi-style': 'error',
'space-before-blocks': 'error',
'space-before-function-paren': ['error', 'never'],
'space-in-parens': 'error',
'space-infix-ops': 'error',
'space-unary-ops': 'error',
'spaced-comment': ['error', 'always', { 'block': { 'balanced': true } }],
'switch-colon-spacing': 'error',
'template-tag-spacing': 'error',
'unicode-bom': 'error',
'wrap-regex': 'error',

// ECMASCRIPT 6
'arrow-body-style': ['error', 'always'],
'arrow-parens': ['error', 'as-needed'],
'arrow-spacing': 'error',
'generator-star-spacing': 'error',
'no-confusing-arrow': 'error',
'no-duplicate-imports': 'error',
'no-useless-computed-key': 'error',
'no-useless-constructor': 'error',
'no-useless-rename': 'error',
'no-var': 'error',
'object-shorthand': 'error',
'prefer-arrow-callback': 'error',
'prefer-const': 'error',
'prefer-destructuring': 'error',
'prefer-numeric-literals': 'error',
'prefer-rest-params': 'error',
'prefer-spread': 'error',
'prefer-template': 'error',
'rest-spread-spacing': 'error',
'symbol-description': 'error',
'template-curly-spacing': 'error',
'yield-star-spacing': 'error',

}
};
1 change: 1 addition & 0 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
uses: github/super-linter/slim@v4
env:
VALIDATE_ALL_CODEBASE: false
VALIDATE_JAVASCRIPT_STANDARD: false
VALIDATE_NATURAL_LANGUAGE: false
# Change if your main branch differs
DEFAULT_BRANCH: main
Expand Down
130 changes: 130 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*
.pnpm-debug.log*

# Diagnostic reports (https://nodejs.org/api/report.html)
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage
*.lcov

# nyc test coverage
.nyc_output

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Snowpack dependency directory (https://snowpack.dev/)
web_modules/

# TypeScript cache
*.tsbuildinfo

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional stylelint cache
.stylelintcache

# Microbundle cache
.rpt2_cache/
.rts2_cache_cjs/
.rts2_cache_es/
.rts2_cache_umd/

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variable files
.env
.env.development.local
.env.test.local
.env.production.local
.env.local

# parcel-bundler cache (https://parceljs.org/)
.cache
.parcel-cache

# Next.js build output
.next
out

# Nuxt.js build / generate output
.nuxt
dist

# Gatsby files
.cache/
# Comment in the public line in if your project uses Gatsby and not Next.js
# https://nextjs.org/blog/next-9-1#public-directory-support
# public

# vuepress build output
.vuepress/dist

# vuepress v2.x temp and cache directory
.temp
.cache

# Docusaurus cache and generated files
.docusaurus

# Serverless directories
.serverless/

# FuseBox cache
.fusebox/

# DynamoDB Local files
.dynamodb/

# TernJS port file
.tern-port

# Stores VSCode versions used for testing VSCode extensions
.vscode-test

# yarn v2
.yarn/cache
.yarn/unplugged
.yarn/build-state.yml
.yarn/install-state.gz
.pnp.*
9 changes: 9 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"eslint.validate": [
"html",
"javascript"
],
"editor.codeActionsOnSave": {
"source.fixAll": true
},
}
ctcpip marked this conversation as resolved.
Show resolved Hide resolved
Loading