Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 29 not working on autofill Enter key #14

Open
ghost opened this issue May 8, 2014 · 5 comments
Open

Firefox 29 not working on autofill Enter key #14

ghost opened this issue May 8, 2014 · 5 comments
Milestone

Comments

@ghost
Copy link

ghost commented May 8, 2014

Hi, i'm using this polyfill but in Firefox 29.0 it won't work , if i autofill via tab or mouse its ok but if i autofill via enter key it doesn't works, any clue?

I'm on MacOSX using the latest Firefox version 29.0
thanks

@tbosch
Copy link
Owner

tbosch commented May 14, 2014

Hi,
can you reproduce this via the examples in this project (aka the manual tests)?

@ghost
Copy link
Author

ghost commented May 15, 2014

Hey sure!
Check , i tested this (saving credentials by browser) both on Chrome latest version and Firefox 29.0.1 (latest) http://plnkr.co/edit/YxFyVgfU2mAbPX0u8OM5?p=preview
For me Chrome works but Firefox not (i type the first email letters and then autofill via keyboard Enter) and i get alerted->
email : myemail@gmail / password: undefined

@ghost
Copy link
Author

ghost commented May 15, 2014

Ah sorry i realized later you need a test/manual/ example or its enought a plunkr? let me know ;)

@ghost
Copy link
Author

ghost commented May 15, 2014

Im enjoying and i was using this autofill lib since few days ago, cause it worked for me on all browers, then Firefox 29.0 and TAC! it does not work anymore, so strange :(

@tbosch
Copy link
Owner

tbosch commented May 21, 2014

Ah, now I understand.
It would be great if you could create a PR that also listens for the enter key, in the same way as the library right now listens to the blur event (see https://github.com/tbosch/autofill-event/blob/master/src/autofill-event.js#L19)?

@ghost
Copy link
Author

ghost commented May 26, 2014

@tbosch Hey mate, it seems to work, may you add the keypress trigger tho?
http://plnkr.co/edit/xpaaUhYmLk6HeRyEQYTX?p=preview

for me it works on FF 29.0.1 and MacOSX,
obviously it needs some better code than mine, i just copied and pasted the
blur listener
replacing blur with keypress
not sure it is a good practice, also cause chrome looks like looping a little bit,
but just check it you tho, it works!

It probably should be trigger autofill only if key pressed is enter?

@ghost ghost changed the title Firefox 29 not working on enter Firefox 29 not working on autofill Enter key May 26, 2014
@wouldgo wouldgo mentioned this issue Jun 13, 2014
@tbosch
Copy link
Owner

tbosch commented Jun 24, 2014

Hi,
just tried using the keypress event (and also the submit event): Both do not solve the problem in Firefox :-(

@tbosch tbosch added this to the 1.0.1 milestone Jul 16, 2014
@wouldgo
Copy link

wouldgo commented Aug 16, 2014

Hi,
haven't seen your reply since I wasn't in this thread. I checked mins ago and you're right... Asap I'll try to review the thing :(

@drewbeck
Copy link

Working for me in OSX FF 31.0, FYI. Angular app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants