Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid test operation #5

Open
NatMarchand opened this issue Dec 16, 2015 · 1 comment
Open

Invalid test operation #5

NatMarchand opened this issue Dec 16, 2015 · 1 comment

Comments

@NatMarchand
Copy link

Hi,
Your test operation is incorrect : it compares Path(target) with target.

The code should be :

protected override void Test(TestOperation operation)
{
    var existingValue = operation.Path.Find(_target);
    if (!existingValue.Equals(operation.Value))
    {
        throw new InvalidOperationException("Value at " + operation.Path.ToString() + " does not match.");
    }
}

Note: I'm unable to make a PR from where I'm writing

@darrelmiller
Copy link
Member

Thanks for the note, I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants