fix(macos): crash on removing menu item #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, all
NSMenuItem
registered to the outer Submenu id, but it's actually added into the inner Submenu'sNSMenu
. When removing the menu item, lines here will call the outer Submenu'sNSMenu
to remove the menu item that is added in the inner Submenu'sNSMenu
hence exception is thrown:muda/src/platform_impl/macos/mod.rs
Lines 634 to 645 in 6454ea2
https://gist.github.com/pewsheen/12b6d63166cd9d0218c0b6c59d260502