-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundation update #13
Conversation
url: endpoint, | ||
|
||
success: function(data, status, statusText) { | ||
success: function(data, status /*, statusText*/) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSHint was not liking that statusText
was defined but not being used. I wanted to keep it there as an argument in case we would use it later and did not want to require a lookup in docs for what the third argument passed would be.
|
Thank you for going over my commits, @sindresorhus. Is there anything else you notice that should be amended before merging? |
|
Yes |
@Glavin001 what you had was fine. I was just thrown off by the |
I wanted to be explicit that it was the
I'll change to |
Awesome stuff :) |
Tasks:
grunt test
Failing #14, test issues: https://travis-ci.org/Glavin001/TasteMusic/jobs/19162734Click a track from the list to play it!