Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension no longer works in Firefox 118 #50

Open
coinshot opened this issue Oct 16, 2023 · 0 comments
Open

Extension no longer works in Firefox 118 #50

coinshot opened this issue Oct 16, 2023 · 0 comments

Comments

@coinshot
Copy link

Hi @tasn,

I love the idea of this extension and wanted to adopt it for some of my projects, however I couldn't get it to work on the latest Firefox. I'm also seeing some weird behaviour on Chrome where it would tell me some pages were signed even though they shouldn't be, which I suspect is because the icon is simply not updated.

I took a quick peek, and I found some issues with the current manifest.json. Then, when attempting to build this locally, some issues popped up due to a lot of the dependencies getting really old.

I suggest to bump the manifest to be compatible with V3, and also rework / bump the extension dependencies themselves.

Next, I was unable to get the icon to work at all with page_action, probably because it's missing the correct show_matches configuration, but got the extension to work again with a simple browser_action.

I can create a PR which bumps all the dependencies to the latest*, and attempts to get this working on the latest browsers again. Let me know if that works for you,and if you have any thoughts.

Thanks

See also:

*One tricky part is that I think the "minimize" extension hasn't been touched in years, and could use an up-to-date alternative, but for that the minification logic should be checked in depth to not break the old behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant