Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the PR/issues comments to the activity report #8

Closed
2 tasks done
gpetiot opened this issue Feb 15, 2024 · 3 comments
Closed
2 tasks done

Add the PR/issues comments to the activity report #8

gpetiot opened this issue Feb 15, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@gpetiot
Copy link
Member

gpetiot commented Feb 15, 2024

reported by @shindere

Tasks

Preview Give feedback
@gpetiot gpetiot added the enhancement New feature or request label Feb 15, 2024
@gpetiot gpetiot transferred this issue from another repository Mar 4, 2024
@shindere
Copy link

shindere commented Mar 4, 2024 via email

@gpetiot
Copy link
Member Author

gpetiot commented Mar 8, 2024

TLDR: I suggest we make it easier for you to post review comments on the CLI

@shindere I had a look at including regular comments in the result of the query and it's a bit more tricky than expected.

The request we have is basically asking for the contributions from the viewer, so we retrieve a contributionsCollection that contains issueContributions, pullRequestContributions, pullRequestReviewContributions and repositoryContributions. And we can easily filter the contributions with the time they happened. So regular comments are not considered contributions and are not contained in the collection.

The "normal way" to get comments would be through a separate field of the query and it is not possible to filter with the date they were posted on.

So unless the comments are one day added to the list of contributions, which I didn't find on their issue tracker, we are stuck here.

But, there is a way to do review comments using the github REST API (link here for reference). Would that be acceptable for you if we develop a small tool doing the right curl request with the right arguments so you can post review comments through the CLI?

@gpetiot gpetiot changed the title Add the PR/issues comments to the result of okra generate Add the PR/issues comments to the activity report Mar 13, 2024
@gpetiot
Copy link
Member Author

gpetiot commented Mar 19, 2024

Both are done, closing this one!

@gpetiot gpetiot closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants