refactor(wallet): public submit transaction API cleanup

[sdbondi]

Problem

Transaction submitting API specifically needs to be cleaned up in the wallet daemon and indexer. The current API leads to confusion.

Proposal 1

Wallet Daemon

Changes here will necessitate updates to tari.js, (possibly) tari-snap, tari-generator and wallet daemon web. Hopefully no changes required for users of tari.js.

transactions.submit - remove deprecated fields and update code
transactions.submit_instructions - still needed? if so, figure out why and if we can use or modify transactions.submit in a clean way that makes sense

One of the main confusion points is the difference between inputs and filled inputs and when to use each. Maybe we should consider splitting the filling from the submitting. i.e. a wallet can look up (in it's db and/or via indexer) which inputs to include for an unsigned transaction and include them (maybe transactions.resolve_inputs). Then it can pass those inputs to transactions.submit, which simply submits the transaction as given.

Indexer

In future, we may never really want to resolve input versions. And If we know the inputs already, having the indexer scan for dependencies for every transaction is not needed and impacts performance. Therefore, I think splitting scanning/input resolving from transaction submitting makes sense.

[sdbondi]

Done in #1151