Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 404 page #224

Open
1 task done
r10513 opened this issue Sep 15, 2023 · 1 comment
Open
1 task done

Custom 404 page #224

r10513 opened this issue Sep 15, 2023 · 1 comment
Assignees
Labels
type:feature_request Feature request

Comments

@r10513
Copy link

r10513 commented Sep 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem to be solved

First of all thank you for your wonderful package!
I would like to use your pages (for instance, the l7-dark template) but with a custom 404 page.

Suggest a solution

Would it be possible to implement an environmental variable, such as CUSTOM_404 that, if not set, has a default to False?
Then, in the docker container, is just a matter to set CUSTOM_404 to true and implement the correct mapping via a volume entry..
Something like

  error-pages:
    image: tarampampam/error-pages:latest
    ports:
      - 8080:8080
    volumes:
      - /path/to/local/404.html:/custom/404.html:ro
    environment:
      TEMPLATE_NAME: l7-dark
      CUSTOM_404:  true
    labels:
      traefik.enable: true

Thank you!

Additional context

No response

@r10513 r10513 added the type:feature_request Feature request label Sep 15, 2023
@tarampampam
Copy link
Owner

Hello and thank you for raising this issue! May I ask why you chose to override only one (or a few) error pages, instead of creating a custom template to cover all error codes? What is the reason for using a custom template for only one specific code? I am asking because I am currently working on a new major version of the error-pages and would like to understand the reasoning behind this approach to determine if it should be implemented in a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature_request Feature request
Projects
None yet
Development

No branches or pull requests

2 participants