Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sente v1.21 roadmap (future release) #456

Open
7 tasks
ptaoussanis opened this issue Nov 14, 2024 · 3 comments
Open
7 tasks

Sente v1.21 roadmap (future release) #456

ptaoussanis opened this issue Nov 14, 2024 · 3 comments
Assignees

Comments

@ptaoussanis
Copy link
Member

ptaoussanis commented Nov 14, 2024

@ptaoussanis ptaoussanis self-assigned this Nov 14, 2024
@awb99
Copy link

awb99 commented Nov 26, 2024

please update the demo/docs so that heartbeat useage is clearer.
I would say that the connection handling part of sente is the least documented,
with releases in the last 2 years a lot of things has improved (stale connections seem to
no longer occur), so it is important that everything related to state change is better documented.

  • :ws-kalive-ms client side, server side or both? it says they should not be equal, why?
  • :ws-ping-timeout-ms what happens thereafter? client side, server side or both?
  • is this necessary:
(defmethod -event-msg-handler :chsk/ws-ping
  [{:as _msg :keys [event _id _?data _ring-req ?reply-fn _send-fn]}]
  (infof ":chsk/ws-ping: %s" event)
  (when ?reply-fn
    (?reply-fn {:unmatched-event-as-echoed-from-server event})))

(defmethod -event-msg-handler :chsk/ws-pong
  [{:as _msg :keys [event _id _?data _ring-req ?reply-fn _send-fn]}]
  (infof ":chsk/ws-pong: %s" event)
  (when ?reply-fn
    (?reply-fn {:unmatched-event-as-echoed-from-server event})))
  • note that the demo uses a old version of sente, so most likely needs to be changed.

@awb99
Copy link

awb99 commented Nov 26, 2024

Why not move to telemere both clj and cljs? This would be a nice usecase at least.

@ptaoussanis
Copy link
Member Author

@awb99 Thanks for the suggestions. Sente's documentation and examples could definitely do with a lot of updating and improvement - have just been triaging efforts and these didn't seem like a priority.

Happy to reconsider though if there's interest.

is this necessary:

Just to answer this one so long - this has never been necessary, it's just there to illustrate that you can use these events if you like. That should be made clear, I hadn't considered that someone might interpret it as a requirement.

BTW PRs welcome if you or anyone else had small improvements like this to suggest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants